Skip to main content
cancel
Showing results for 
Search instead for 
Did you mean: 

Register now to learn Fabric in free live sessions led by the best Microsoft experts. From Apr 16 to May 9, in English and Spanish.

Reply
Tontaube2
Helper IV
Helper IV

Import Excels from folder: Filter first, combine after - or combine first, filter after

Hi,

 

I'm importing xlsx from a folder. Each xlsx has 3 sheets.

My question is: What is "better"?

A) Open binaries, open tables, filter for correct sheet (Companies, Answers, Filters) - and combine each sheet afterwards

-> Only one Query + Helper query, but multiple additional steps to take inside each sheet

A.jpg

 

B) Combine tables, subquery for correct sheets and combine them

-> Multiple queries, but less many steps inside each sheet (Also because you already can format 3 different example files BEFORE final combining)

 

B.jpg

 

I don't have to refresh that often. Amount of data is & will be quite small.

 

1 ACCEPTED SOLUTION
edhans
Super User
Super User

Never click on that "binary" link when you have selected a folder unless you will never need to change it. The path gets hardcoded in the M code. You can change it, but it is annoying.

 

Combine, then do the changes. For 3 files it really doesn't matter, but if you need a 4th file, the combine first will scale automatically. Or a 40th file.



Did I answer your question? Mark my post as a solution!
Did my answers help arrive at a solution? Give it a kudos by clicking the Thumbs Up!

DAX is for Analysis. Power Query is for Data Modeling


Proud to be a Super User!

MCSA: BI Reporting

View solution in original post

3 REPLIES 3
Tontaube2
Helper IV
Helper IV

Thank you both!

 

I was incommunicado, just returned to work.

smpa01
Super User
Super User

@Tontaube2  a fatser and better way (I think) when you are connecting to a folder and performing same transformation (filtering in this case) on each folder contents (excel), I guess a better way to run transformation is through ODBC connection cause you can write SQL query for transformation within that connector before combining.

 

Let's suppose your excel (m1.xlsx) looks like this which resides in C:\Users\user1\Documents\New folder

smpa01_0-1634318667089.png

 

and you want to get only Answers from ther, you can do it in following way

 

 

Odbc.Query("dbq=C:\Users\user1\Documents\New folder\m1.xlsx;defaultdir=C:\USERS\user1\DOCUMENTS;driverid=1046;maxbuffersize=2048;pagetimeout=5;dsn=Excel Files", "SELECT `Answers$`.*#(lf)FROM `C:\Users\user1\Documents\New folder\m1.xlsx`.`Answers$` `Answers$`#(lf)")

 

 

 

smpa01_1-1634318841457.png

 

The benefit of this approach is you can write SQL queries here for transformation so that PQ gives you a cleaned and transformed table from step1 itself.

 

Now, if you want to iterate this for each folder content, do the following  to parametrize the file name in the query string like this

Odbc.Query("dbq=C:\Users\user1\Documents\New folder\"&[Name]&";

 

 

 

let
    Source = Folder.Files("C:\Users\user1\Documents\New folder"),
    #"Added Custom" = Table.AddColumn(Source, "Custom", each Odbc.Query("dbq=C:\Users\user1\Documents\New folder\"&[Name]&";defaultdir=C:\USERS\user1\DOCUMENTS;driverid=1046;maxbuffersize=2048;pagetimeout=5;dsn=Excel Files", "SELECT `Answers$`.*#(lf)FROM `C:\Users\user1\Documents\New folder\m1.xlsx`.`Answers$` `Answers$`#(lf)")),
    #"Removed Other Columns" = Table.SelectColumns(#"Added Custom",{"Custom"}),
    #"Expanded Custom" = Table.ExpandTableColumn(#"Removed Other Columns", "Custom", {"Month", "Transaction"}, {"Month", "Transaction"})
in
    #"Expanded Custom"

 

 

 

This would  require you to fill in credential which can be set to Windows

 

smpa01_2-1634319154777.png

 

 

Did I answer your question? Mark my post as a solution!
Proud to be a Super User!
My custom visualization projects
Plotting Live Sound: Viz1
Beautiful News:Viz1, Viz2, Viz3
Visual Capitalist: Working Hrs
edhans
Super User
Super User

Never click on that "binary" link when you have selected a folder unless you will never need to change it. The path gets hardcoded in the M code. You can change it, but it is annoying.

 

Combine, then do the changes. For 3 files it really doesn't matter, but if you need a 4th file, the combine first will scale automatically. Or a 40th file.



Did I answer your question? Mark my post as a solution!
Did my answers help arrive at a solution? Give it a kudos by clicking the Thumbs Up!

DAX is for Analysis. Power Query is for Data Modeling


Proud to be a Super User!

MCSA: BI Reporting

Helpful resources

Announcements
Microsoft Fabric Learn Together

Microsoft Fabric Learn Together

Covering the world! 9:00-10:30 AM Sydney, 4:00-5:30 PM CET (Paris/Berlin), 7:00-8:30 PM Mexico City

PBI_APRIL_CAROUSEL1

Power BI Monthly Update - April 2024

Check out the April 2024 Power BI update to learn about new features.

April Fabric Community Update

Fabric Community Update - April 2024

Find out what's new and trending in the Fabric Community.

Top Solution Authors
Top Kudoed Authors