Optimizing a query with repetitive conditions in a filter

[Anonymous]

Hi all,

I'm currently trying to optimize a measure that takes a while to load : 

MyMeasure:=
CALCULATE (
    [Submeasure],
    USERELATIONSHIP ( Sales[IdMember], 'Members'[IdMember] ),
    FILTER (
        'Members',
        'Members'[Metier] <> "Chef"
            && 'Members'[Metier] <> "Agriculteur"
            && 'Members'[Metier] <> "Fonctionnaire"
            && 'Members'[Metier] <> "Comptable"
            && 'Members'[Metier] <> BLANK ()
    )
)

I do know that a common good practice is to refactor repeated values in a variable, but in this case, I don't think it would work since variables are a constant and in this case Metier changes for every line we're filtering.

When it comes to the submeasure, I just recently optimized it by precalculating some values in the source view.

SubMeasure :=
VAR lastPeriod = 'Time'[LastPeriod]
RETURN
    CALCULATE (
        [IsOK],
        FILTER (
            ALL ( Managing[PeriodLastSale], Managing[idPeriodEntry] ),
            IF (
                ISBLANK ( Managing[PeriodLastSale] ),
                IF ( lastPeriod - Managing[idPeriodEntry] < 5, TRUE (), FALSE () ),
                IF ( lastPeriod - Managing[PeriodLastSale] < 5, TRUE (), FALSE () )
            )
        )
    )

Right now this parent measure takes a pretty long time to load, do you have an idea how I could optimize it ?

(The names are just mock names to convey the idea).

Kindly,

Nossair

[ppm1 · Accepted solution]

It is not good practice to filter a whole table in your CALCULATE, so your first measure could be written like this.

MyMeasure :=
CALCULATE (
    [Submeasure],
    USERELATIONSHIP ( Sales[IdMember], 'Members'[IdMember] ),
    NOT ( 'Members'[Metier] IN { "Chef", "Agriculteur", "Fonctionnaire", "Comptable", "" } )
)

Also, it is likely your submeasure may be causing the problem. Having IF (and nested IF, in your case) evaluated on each row of an iterator like FILTER will slow it down. You could likely rewrite it with AND or && instead of doing IFs.

Plus, your LastPeriod variable appears to be a column reference. Is that a measure?

Pat