dashboard share not working

BarryAP Do you mean content pack or sharing dashboard invidually as they are two different process. If you've created and shared content pack with users then those users need to go to their power bi serivce portal -> Get Data -> My organisation and then get content pack. If you've shared individually then they should receive email -> click on the link in email and should be able to access. 

I would suggest you start by sending dashboard url (not sharing just sending them url without sharing) to the users within your organisation. Once they access that URL they will be presented with a page that says 'You don't have access to this dashboard, click to request access to this dahsboard'. This will send you an email requesting access by that person to the dashboard and you grant them and see if that works for them to access the dashboard.