Forum Discussion

SaaM's avatar
SaaM
Helper II
5 years ago
Solved

Refactor a function

Hello,

 

I am trying to refactor this function that I apply on 10 differents columns.

 

fnConcatenate = (tbl as table) => Table.AddColumn(tbl, "field_1_combined", each if [id]>[linenumber] then Text.Combine(Table.SelectRows(tbl, (sel)=> sel[key] = [key] and sel[id]>= [id])[#"field_1"]) else [#"field_1"]),


fnConcatenate = (tbl as table) => Table.AddColumn(tbl, "field_2_combined", each if [id]>[linenumber] then Text.Combine(Table.SelectRows(tbl, (sel)=> sel[key] = [key] and sel[id]>= [id])[#"field_2"]) else [#"field_2"]),
 
... 

fnConcatenate = (tbl as table) => Table.AddColumn(tbl, "field_10_combined", each if [id]>[linenumber] then Text.Combine(Table.SelectRows(tbl, (sel)=> sel[key] = [key] and sel[id]>= [id])[#"field_10"]) else [#"field_10"]),

 

Is it possible to have something like this

 

fnConcatenate = (tbl as table, field as text) => Table.AddColumn(tbl, "field" + "_combined", each if [id]>[linenumber] then Text.Combine(Table.SelectRows(tbl, (sel)=> sel[key] = [key] and sel[id]>= [id])[#"field"]) else [#"field"]),

?

 

Thanks

 

Kind regards

Saam

  • Anonymous's avatar
    Anonymous
    5 years ago

    try

     

     

     

    fnConcatField = (tbl as table, field as text) => Table.AddColumn(tbl, field & "_combined", each 
                                    if [id]>[linenumber] then Text.Combine( Table.Column(Table.SelectRows(tbl, (sel)=> sel[key] = [key] and sel[id]>= [id]), field)) else Record.Field(_, field))

     

     

    try something like this (I haven't tested it)  

3 Replies

Replies have been turned off for this discussion
  • Anonymous's avatar
    Anonymous
    Not applicable

    try

     

     

     

    fnConcatField = (tbl as table, field as text) => Table.AddColumn(tbl, field & "_combined", each 
                                    if [id]>[linenumber] then Text.Combine( Table.Column(Table.SelectRows(tbl, (sel)=> sel[key] = [key] and sel[id]>= [id]), field)) else Record.Field(_, field))

     

     

    try something like this (I haven't tested it)  

  • Column names can be created dynamically

     

    fnConcatenate = (tbl as table, field as text) => Table.AddColumn(tbl, field + "_combined", 

     

    but they cannot be referenced (easily) dynamically. Have you considered using Expression.Evaluate() for this?

    • SaaM's avatar
      SaaM
      Helper II

      I never used Expression.Evaluate()

      I will look for this approach

       

      Thanks

       

      Kind regards,

      Saam