% Change Year over Year

[Card14x]

Hi,

I am trying to create a measure formula that calculates the % change year over year that also takes into account changes from negative to positive numbers. I have the formula written out in excel below, but when I try to get the same formula written in PBI I get an error saying too few arguments passed. Any help would be greatly appreciated. 

Excel Formula

=IF(LY %=0,0,(IF(LY %<0,(( LY % - TY %)/ LY %)*100,(( LY % - TY %)/ LY %)*-100)))

PBI Measure

% Change Calculated = IF([LY Shortage Rate Calculated]=0,0,IF([LY Shortage Rate Calculated]>0,([LY Shortage Rate Calculated]-[TY Shortage Rate Calculated]/[LY Shortage Rate Calculated])*-1,IF([LY Shortage Rate Calculated]-[TY Shortage Rate Calculated]/[LY Shortage Rate Calculated])))

[dedelman_clng · Accepted solution]

You have an extra IF towards the end.  Should be

% Change Calculated =
IF (
    [LY Shortage Rate Calculated] = 0,
    0,
    IF (
        [LY Shortage Rate Calculated] > 0,
        ( [LY Shortage Rate Calculated]
            - [TY Shortage Rate Calculated] / [LY Shortage Rate Calculated] )
            * -1,
        ( [LY Shortage Rate Calculated]  ##You had an extra IF here
            - [TY Shortage Rate Calculated] / [LY Shortage Rate Calculated] )
    )
)

[dedelman_clng · Accepted solution]

You have an extra IF towards the end.  Should be

% Change Calculated =
IF (
    [LY Shortage Rate Calculated] = 0,
    0,
    IF (
        [LY Shortage Rate Calculated] > 0,
        ( [LY Shortage Rate Calculated]
            - [TY Shortage Rate Calculated] / [LY Shortage Rate Calculated] )
            * -1,
        ( [LY Shortage Rate Calculated]  ##You had an extra IF here
            - [TY Shortage Rate Calculated] / [LY Shortage Rate Calculated] )
    )
)

[Card14x · Accepted solution]

Thanks for the quick reply Dedelman_clng! I added in some divides into the formula with your change and it worked perfectly. 

% Change Calculated =
IF (
    [LY Shortage Rate Calculated] = 0,
    0,
    IF (
        [LY Shortage Rate Calculated] > 0,
       **DIVIDE** ( [LY Shortage Rate Calculated]
            - [TY Shortage Rate Calculated] , [LY Shortage Rate Calculated] )
            * -1,
        **DIVIDE**( [LY Shortage Rate Calculated] - [TY Shortage Rate Calculated] , [LY Shortage Rate Calculated] )
    )
)