Is this function written poorly?

Hi Jkaelin,

What is your actually problem with above DAX formula? What did you mean "looks poorly written (poor performance)"?

For its format, it looks tidy and clear. For its performance, it looks like not a complex logic. Acording to current information, this function look fine. Whether it is the best appropriate method, it depends on your detailed data in actual environment.

Here are some articles written about optimizing DAX performance:

Tune your PowerPivot DAX query, don’t use the entire table in a FILTER and replace SUMX if possible

DAX Best Practices

Optimize DAX expressions involving multiple measures

Best regards,
Yuliana Gu